Replace swagger urls in org.springdoc.core.properties.AbstractSwaggerUiConfigProperties#urls only if url is changed. Test to check if the issue is fixed. Fixes #2509.
#2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rUiConfigProperties.urls` only if url is changed. Test to check if the issue is fixed. Fixes springdoc#2509.
dgswan
force-pushed
the
bugfix/T-2509-fix-array-index-out-of-bounds-exception-in-swagger-ui-config-parameters
branch
from
732a2e8 to
2af8626
Compare
springdoc-openapi-starter-common/src/main/java/org/springdoc/ui/AbstractSwaggerWelcome.java
Outdated
Show resolved
Hide resolved
…figProperties.urls` and replace it with mutation of `org.springdoc.core.properties.AbstractSwaggerUiConfigProperties.SwaggerUrl.url` when necessary. Enhance `SpringDocApp8MultipleUrlsSeveralParallelRequestsTest` by specifying custom servlet path to check no exception is thrown.
dssievewright
approved these changes
Aug 18, 2024
dgswan
deleted the
bugfix/T-2509-fix-array-index-out-of-bounds-exception-in-swagger-ui-config-parameters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace swagger urls in
org.springdoc.core.properties.AbstractSwaggerUiConfigProperties#urlsonly if url is changed. Test to check if the issue is fixed. Fixes #2509.